jacobseiler / rsage

The Reionization using Semi-Analytic Galaxy Evolution model.
MIT License
1 stars 0 forks source link

Splitting of Ejected Gas Redone (PR #10, Issue #9) #11

Closed jacobseiler closed 6 years ago

jacobseiler commented 6 years ago

As was stated in the earlier pull request, the explicit tracking of ejected gas through supernovae/quasar channels was disabled. This was due to the way that I dealt with reincorporation/infall of gas from the Ejected Reservoir back into the galaxy.

In the previous commit d59f176 we reduced the amount of ejected gas through each channel equally. However this doesn't make sense because if we had 90% of gas ejected from supernova and 10% from quasars, it doesn't follow physically to reduce these channels by the same amount.

This PR instead keeps the fraction of SN/QSO ejected gas the same whenever there is a reincorporation/infall event. The XASSERT statements were re-added and they all pass.

Previous PR #10 and Issue #9