jacobseiler / rsage

The Reionization using Semi-Analytic Galaxy Evolution model.
MIT License
1 stars 0 forks source link

Name of Nion files is cumbersome for the user #15

Closed jacobseiler closed 5 years ago

jacobseiler commented 6 years ago

Currently the different fescPrescription values produce files that are named differently, with a further dependance on the calibration values used. Whilst we are able to use utility scripts to adjust these correctly, it is cumbersome for the user.

An update needs to occur where after calling init_cifog() we manually change the value of the Nion file parameter in the cifog simParam variable.

jacobseiler commented 6 years ago

However the problem here is then the integration into the plotting scripts. These scripts use the .ini files as drivers, so by updating only the cifog simParam variable we will not be pointing to the correct file in the .ini file.

jacobseiler commented 6 years ago

However, once again, the correct Nion file could simply be reconstructed from the .ini file parameters. Hence I'd need to update the Python script to properly reflect this.

So the TLDR of the fix is:

jacobseiler commented 5 years ago

Stop being stupid.

The correct way to do this is to allow the user to use a dummy field name (None) to force RSAGE to handle all the naming itself.

What I will do is at the beginning of RSAGE, after reading in the .ini files, is create a determine_file_paths() function. This will in essence use my Python script and generate the paths on-the-fly without the user having to run any extra or auxillary scripts.