search

jacobslusser / ScintillaNET

A Windows Forms control, wrapper, and bindings for the Scintilla text editor.
MIT License
963 stars 243 forks source link

.NET Core 3.0 compatible #469

Open msneijders opened 4 years ago

msneijders commented 4 years ago

Currently a net40 dll is released. This version does not work using .NET Core 3.0. Reason is the use of Mutex.SetAccessControl. In .NET Core this is an extension method instead of an instance method in NET40.

Request: use a multitarget project and also release a .NET Core 3.0 version.

I already tried this and it builds and runs without any code changes.

fernandreu commented 4 years ago

I went ahead and created a fork that targets both .NET Framework 4.6.1 and .NET Core 3.1. This is both in GitHub and NuGet. I am using the latest version of this repo (v4.x), together with the fix in #447. If there is interest, I can create a pull request here.

No strong reason to choose those two versions in particular, other than .NET Framework 4.6.1 being quite common (for being the first one supporting .NET Standard 1.4-2.0 I guess) and .NET Core 3.1 being long-term supported (LTS). I could lower this if somebody needs it.

jacobslusser commented 4 years ago

Thank you!

steffen-wilke commented 4 years ago

Thank you!

@jacobslusser Are there any plans to merge these changes into the original repository and release a new version of the official NuGet package. It would be highly appreciated!