jacobson3 / VI-Peek

MIT License
4 stars 3 forks source link

Window placement and sizing. #15

Closed qalldredge closed 3 years ago

qalldredge commented 3 years ago

I'm not sure if the window placement and sizing should be done how it is now. Sometimes the resizing places the title bar off of the screen to the top (if close to the top of the screen and opening a large Block Diagram).

Options could include:

jacobson3 commented 3 years ago

Whatever is done now is clearly not working well. The original idea came from Visual Studio's peek definition functionality which is why I wanted this window to automatically open up right next to the VI you selected. This is easier said than done as you run into all sorts of issues with the window getting too big, going out of bounds, or crossing from one monitor to another. Breaking these into two separate issues:

Moving: I'm not sure I even like this behavior myself. I implemented a pin behavior which basically meant that the window wouldn't move or resize (it does on "previous" or "choose implementation" but those can be fixed) and when I was actually using this tool myself I much preferred keeping the window pinned.

Resizing: This would seem to be intuitively correct, I always want to see the whole block diagram obviously, but I think when you're using the tool having the window resize on you feels more jarring than anything.

I'll probably create a branch and implement your second bullet point. From there maybe we see if resizing down and to the right (with some maximum) would be a good addition. If neither of those options end up feeling good I can just delete the branch.

jacobson3 commented 3 years ago

@qalldredge I created a Window-Resize branch which implements the second bullet point (and made a few small changes to make sure the window hides when it should). Let me know if this window behavior is better than what we currently have.

qalldredge commented 3 years ago

@jacobson3 I think I like this better. Then it's not always moving and shifting around.