search

jacobson3 / VI-Peek

MIT License
4 stars 3 forks source link

Improve Malleable VI Naming #17

Closed jacobson3 closed 2 years ago

jacobson3 commented 3 years ago

If you select a malleable VI it will open up the standard VI (the implementation given the input data types) but this results in the malleable VI using a nonsense name as shown below.

2f4716db-bacd-4fb1-89da-d0e816fd5f11.vi

Ideally we can get that to show up as .vim. The above VI name is correct but not actually helpful to users.

qalldredge commented 3 years ago

I did not find an easy way to correlate the instance name back to the actual name but I did find a way. Should I replace the instance name with the actual name in the stack entirely or just as it shows in the tree? This will have the effect of showing and opening the actual VIM and not the instance in the subpanel. Or should we show the instance? Or should we allow both similar to the dynamic dispatch VIs?

jacobson3 commented 3 years ago

Personally I would want to show the specific instance but have the name appear as it would on disk (like malleable_function.vim).

qalldredge commented 3 years ago

I don't know. It might be nice showing the instance but it might be confusing. The instance code is usually not visible unless you convert the instance into a Standard VI and then it ceases being a Malleable VI. Also, you shouldn't open and try to edit the instance code. I think it should either be the Actual VIM only or we should have some way to have both but the instance should not be openable.

qalldredge commented 2 years ago

Hopefully, this is fixed with the merging of my OO branch. Check it out and if you think it is sufficient, my recommendation is to close this issue.

jacobson3 commented 2 years ago

I think you're right, I'll double check this.

jacobson3 commented 2 years ago

You're correct, this was resolved in #21