search

jacobson3 / VI-Peek

MIT License
4 stars 3 forks source link

Feature Addition: Peek Window Scroll #32

Closed ItsMeAshiq closed 2 years ago

ItsMeAshiq commented 2 years ago

Improvement

Made some improvements in the VI resize operation.

New Feature

Implemented Scroll Feature into the Peek window.

Now, users can scroll the Peek Window as similar to scrolling normal VIs.

VI Peek Window Scroll

Possible Scroll Operations

Normal Scroll → Scrolls Vertically Shift + Scroll → Scrolls Vertically with extra distance Alt + Scroll → Scrolls Horizontally Shift + Alt + Scroll → Scrolls Horizontally with extra distance

jacobson3 commented 2 years ago

Cool addition, I'll have to mess with this more later but from a quick look I'm wondering if the BD vs FP check is really necessary.

jacobson3 commented 2 years ago

@ItsMeAshiq Also, is there a reason why you removed the "Panel_PeekSubpanel: Mouse Down?" event? There doesn't seem to be any bad interactions between that event and the scroll event that you added.

ItsMeAshiq commented 2 years ago

Cool addition, I'll have to mess with this more later but from a quick look I'm wondering if the BD vs FP check is really necessary.

Thought to also include Front Panel into the Peek Window for Future version, so with a Ctrl + E shortcut, Front Panel can also be peeked.

This FP addition to the Peek Window would be very useful if the user wants to peek the FP during their drill down.

And if a front panel is inserted into a sub panel, it implicitly has the scroll features except the Alt + Scroll → Horizontal Scroll.

I think that alone can be added to the FP Scroll once FP peeking is added.

ItsMeAshiq commented 2 years ago

@ItsMeAshiq Also, is there a reason why you removed the "Panel_PeekSubpanel: Mouse Down?" event? There doesn't seem to be any bad interactions between that event and the scroll event that you added.

Yeah, it was messing with the Block Diagram, while panning its contents using Ctrl + Shift + Mouse Down + Mouse Drag.

Such as, when panning is started with the inserted Block Diagram, parallelly mouse down event is processed on the Peek VI. Then even after releasing the mouse, the Block Diagram still being in the panning mode and pans the diagram at unexpected positions.

VI Peek Window Drag Issue

It stops only after after a Mouse Down on the block diagram.

After removing that Mouse Down Filter Event from the Event Structure, that behavior has changed.

VI Peek Window Drag Fixed

ItsMeAshiq commented 2 years ago

And I have discovered a bug with this scroll, while scrolling over the Scroll Bars, it still implements the below mentioned interactions,

Possible Scroll Operations

Normal Scroll → Scrolls Vertically Shift + Scroll → Scrolls Vertically with extra distance Alt + Scroll → Scrolls Horizontally Shift + Alt + Scroll → Scrolls Horizontally with extra distance

It can be updated. Let me have some time to commit changes for this addition.

ItsMeAshiq commented 2 years ago

And I have discovered a bug with this scroll, while scrolling over the Scroll Bars, it still implements the below mentioned interactions,

Possible Scroll Operations

Normal Scroll → Scrolls Vertically Shift + Scroll → Scrolls Vertically with extra distance Alt + Scroll → Scrolls Horizontally Shift + Alt + Scroll → Scrolls Horizontally with extra distance

It can be updated. Let me have some time to commit changes for this addition.

This bug is fixed with this commit

jacobson3 commented 2 years ago

@ItsMeAshiq I merged the pull request but will have to revert the last commit. You're closing out the reference to the object that's inserted into the subPanel which basically causes your feature to not work (and even crashes my LabVIEW semi-reliably.