search

jacobsvante / bgtunnel

Initiate SSH tunnels in the background in python
MIT License
48 stars 16 forks source link

decode ssh_path to utf-8, as shlex in Python 3.3 has some bugs with the ... #3

Closed metakermit closed 10 years ago

metakermit commented 10 years ago

...bytes type

Works on Python 2.7.5 and 3.3 now.

jacobsvante commented 10 years ago

kermit666 could you perhaps add a test for this change?

metakermit commented 10 years ago

@jmagnusson will this do? It passes locally on my machine in Python 2 and 3.

metakermit commented 10 years ago

Ah... I thought six was in the standard library. Let me add it to test_requirements.txt and see if that makes Travis happy.

jacobsvante commented 10 years ago

Merged! Thanks for your contribution @kermit666

metakermit commented 10 years ago

No problem, thanks for merging @jmagnusson . That completes switching my web dev stack to Python 3 :)

jacobsvante commented 10 years ago

Lucky you! I still depend on a lot of py2-only packages :-(

metakermit commented 10 years ago

Well, you can try to see which are the main ones you depend on and help convert them too. Right now I'd say 90% of the most important ones are converted:

https://python3wos.appspot.com/

Cheers!

jacobsvante commented 10 years ago

Yeah when/if I get some more spare time I will definitely contribute back more than I do today. Nice site btw!