jacobsvante / netsuite

Make async requests to NetSuite SuiteTalk SOAP/REST Web Services and Restlets
https://jacobsvante.github.io/netsuite/
MIT License
102 stars 55 forks source link

searchMoreWithId functionality to SOAP interface #71

Closed vlouvet closed 10 months ago

vlouvet commented 10 months ago
codecov[bot] commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f903be7) 35.71% compared to head (91a18c3) 35.80%.

Files Patch % Lines
netsuite/soap_api/client.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #71 +/- ## ========================================== + Coverage 35.71% 35.80% +0.08% ========================================== Files 25 25 Lines 1064 1067 +3 ========================================== + Hits 380 382 +2 - Misses 684 685 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

iloveitaly commented 10 months ago

@vlouvet flake8 check is still failing, can you resolve?

vlouvet commented 10 months ago

@iloveitaly I will create a separate PR to add robust tests to the soap and rest API - but all checks passing now.

vlouvet commented 10 months ago

@iloveitaly this is ready