jacobtomlinson / carte-noire

A simple jekyll theme for blogging
http://carte-noire.jacobtomlinson.co.uk/
Other
298 stars 219 forks source link

added mathjax for latex support #58

Closed ghost closed 8 years ago

jacobtomlinson commented 8 years ago

I like this. However it does introduce a new dependancy and request which is loaded on every page.

I think it would be sensible to have this an an optional include, that you can enable un the frontmatter of an article. This could either look like:

mathjax: true

or

javascript:
 - mathjax

or similar.

The second allows for future things like D3 to also be added but also adds complication. I'll leave it to you to come up with something.

ghost commented 8 years ago

Hello, Jacob!

I added, that mathjax only gets loaded, when it's needed. Thanks to kramdown: http://kramdown.gettalong.org/math_engine/mathjax.html

jacobtomlinson commented 8 years ago

Looks good. Although it has a bug, see commit comment.

ghost commented 8 years ago

fixed

jacobtomlinson commented 8 years ago

Great! That's a really neat fix.

Could you finally just add a example of this in the Carte Noire in Action article so that people can see it in use.

ghost commented 8 years ago

Done!