Improvements2 - Githubissues

jacobusmmsmit / DiscreteVoronoi.jl

Julia implementation of various algorithms for calculating discrete Voronoi diagrams.

MIT License

5 stars 1 forks source link

Improvements2 #6

Closed jacobusmmsmit closed 2 years ago

jacobusmmsmit commented 2 years ago

Just some small improvements to the code notably:

Reduce allocations in the exact site filter using filter and a do-block
Make get_sites more idiomatic

goerch commented 2 years ago

Nice! BTW: do you expect the the number of sites computed by exact_site_filter and (the new) jdac_aux3 to be equal?

jacobusmmsmit commented 2 years ago

No I believe it shouldn't necessarily be so: there can be two sites which are very close to each other and a corner, but still both be within most radii, even when one is strictly closer than another. Fundamentally the method of calculating which seeds to exclude is different and can actually be combined.