jacobwb / hashover-next

This branch will be HashOver 2.0
GNU Affero General Public License v3.0
419 stars 87 forks source link

HashOver 2.0 - Cross-Site Scripting (XSS) #152

Closed bestshow closed 7 years ago

bestshow commented 7 years ago

Product:HashOver Download: https://github.com/jacobwb/hashover-next Vunlerable Version: 2.0 and and probably prior Tested Version: 2.0 Author: ADLab of Venustech

Advisory Details: I have discovered a Cross-Site Scripting (XSS) in “HashOver”, which can be exploited to execute arbitrary code. The vulnerability exists due to insufficient filtration of user-supplied data in “hashover-script” HTTP GET parameter passed to “hashover/scripts/widget-output.php” url. An attacker could execute arbitrary HTML and script code in browser in context of the vulnerable website. The exploitation example below uses the "alert()" JavaScript function to see a pop-up messagebox: Poc: http://localhost/.../hashover-next-master/hashover/scripts/widget-output.php?hashover-script=%27;}%3Cscript%3Ealert(1);%3C/script%3Efunction%20test(){

jacobwb commented 7 years ago

Thank you for pointing this out to me, it will be fixed soon. The widget-output.php file does not exist in HashOver 1.0. The widget-output.php file also should not even be executable by itself. Both of these issues have been fixed. The widget code is probably the oldest code in the project, it needs to be entirely rewritten, and improved before release or be removed.