jacobwb / hashover-next

This branch will be HashOver 2.0
GNU Affero General Public License v3.0
420 stars 87 forks source link

Unapproved comments are emailed out to subscribers before they’re approved #322

Open da2x opened 2 years ago

da2x commented 2 years ago

I don’t have a clear idea of how to fix this one. It’s trivial to stop the emails from going out, but then how do you send it ones the status changes? Also, swapping statuses could send the same message multiple times. The database needs to track whether the comment has been sent out as an email or not. The email sending can’t take place in WriteComments. It should probably be async from the posting request anyway.