Migrate to Electron Forge

jacobwhall / marktext

fork of marktext, seeking to modernize our favorite markdown editor

MIT License

124 stars 3 forks source link

Migrate to Electron Forge #4

Open axelrindle opened 1 year ago

axelrindle commented 1 year ago

This PR will migrate the codebase and build process to use Electron Forge + Vite.

Todos

[x] Replace import aliases with relative imports
[x] Replace electron-builder and custom build scripts with electron-forge
[x] The dependency fontmanager-redux seems to be broken or unusable
- Error is: Failed to resolve entry for package "fontmanager-redux". The package may have incorrect main/module/exports specified in its package.json.
- https://github.com/Eugeny/fontmanager-redux
[ ] Migrate tests
[ ] Apply old electron-builder.yml config to Electron Forge
[ ] Update Pipeline
[ ] Update Documentation

I will probably add more Todos as I make migration progress.

axelrindle commented 1 year ago

I think this error is caused by the Renderer Process trying to access Node.js APIs. While this is generally possible by enabling the nodeIntegration for a BrowserWindow, Vite might be having problems with that.

axelrindle commented 1 year ago

Just a small update: I managed to get the application to start with the new Vite workflow, but the renderer does not work yet.

jzhang-gd commented 6 months ago

My work platform is Mac and I’m new to using the MarkText, are there any updates? I'm so excited to find this repo and very appreciative of all of you do the excellent work to maintain it.

jacobwhall commented 6 months ago

Hey @jzhang-gd, thanks for your interest in our work. Unfortunately I only have the bandwidth to build updated versions of this MarkText fork for Linux. I welcome contributions (like this PR!) to update the build process for MacOS, Windows, or other operating systems. As a community of volunteers, we rely on each other's time and expertise to improve this project.

If you would like to receive updates on MacOS support specifically, I recommend subscribing for notifications on issue #2. There is a button to do this on the right side of the page on GitHub.