search

jacobwilliams / json-fortran

A Modern Fortran JSON API
https://jacobwilliams.github.io/json-fortran/
Other
333 stars 82 forks source link

only installing if json-fortran is the top level project #529

Closed K20shores closed 10 months ago

K20shores commented 1 year ago

This puts all of the packaging into its own file and only includes the install targets if this is the top level project. Projects that would add json-fortran with FetchContent, for example, wouldn't install the json-fortran targets

K20shores commented 1 year ago

@jacobwilliams of the three PRs I submitted, I would most like this one to be merged, if you are fine with it.

jacobwilliams commented 1 year ago

I tried pulling your three commits into a develop branch to look at them but there is a conflict between two of them.

K20shores commented 1 year ago

@jacobwilliams Ok. I didn't know if you would be interested in all three. I'll make a branch of all 3 and reconcile them

K20shores commented 1 year ago

I tried pulling your three commits into a develop branch to look at them but there is a conflict between two of them.

Please see #533. I merged all of these changes into one branch and submitted a PR with the changes, as well as addressing your comments about the version file.

jacobwilliams commented 10 months ago

closing in favor of #533