Closed lmdiazangulo closed 3 months ago
Merging #544 (9eaa63f) into master (7819919) will not change coverage. The diff coverage is
n/a
.
It looks like the CI failed? (haven't looked into why)
What is the reason for both JSONFORTRAN_ENABLE_TESTS
and ENABLE_TESTS
? It's not clear to me what the user is supposed to set to get the tests...
(note: the CI is failing because the tests aren't being enabled)
It looks like -D ENABLE_TESTS=ON
enables the tests?
It looks like
-D ENABLE_TESTS=ON
enables the tests?
Yes. I added an option because at some point I was using it as a submodule which was imported with add_subdirectory from a parent cmake. It was a little bit confusing to me that the names in the variables defined by options do not include the name of the project they refer to.
Besides that, thank you a lot for this library. We are using it extensively in our FDTD solver project: https://github.com/OpenSEMBA/fdtd
I think these changes have broken the conda-forge package. The shared library doesn't seem to be being built anymore. Did that get disabled?
We should be getting:
-- Installing: $PREFIX/lib/libjsonfortran.so.8.4.0
-- Installing: $PREFIX/lib/libjsonfortran.so.8.4
-- Installing: $PREFIX/lib/libjsonfortran.so
-- Installing: $PREFIX/lib/libjsonfortran.a
Now we are only getting:
-- Installing: $PREFIX/lib/libjsonfortran.a
See #558
Yes, maybe I disabled that while doing some tests. Maybe is better to revert the merge. Sorry about that.
I have found some issues trying to compile with the recent Intel One API + Visual Studio 2022. Basically I got this error.
I have implemented some changes in CMakeLists.txt to fix it by considering the case of IntelLLVM which is the compiler Id of the new compiler.
Best regards, Luis