search

jacobwojoski / dice-stats

A Module for Foundry VTT that tracks and displays dice stats
MIT License
7 stars 6 forks source link

[System Request] SWADE #7

Closed brunocalado closed 1 year ago

brunocalado commented 1 year ago

Great module!

Can you make it work for SWADE?

jacobwojoski commented 1 year ago

Will need to see how rolls are done In those systems. As long as it posts rolls to a central area it should be easy enough. If roll data isn’t global then it would be a lot harder

brunocalado commented 1 year ago

Thank you.

But, SWADE has a exploding die feature.

If you roll the max number on a die, you roll again and sum up. image

Is it possible to take this in account?

jacobwojoski commented 1 year ago

Possible but need to learn and look into how to check what system is being run. Then change how chat dice parsing works for this system specifically. Looking into the system the exploding dice are not part of the Chat message ROLLS[ ] data and instead are a special custom field. So it will take a bit to get it working.

jacobwojoski commented 1 year ago

Give it a shot now and see if this works New update in 1.5.0 might have fixed it.

Should have fixed it

brunocalado commented 1 year ago

Give it a shot now and see if this works New update in 1.5.0 might have fixed it.

Should have fixed it

Thankyou, but I can't see the exploding dice. Also, there is an error when I click refresh image

jacobwojoski commented 1 year ago

Any chance you could disable all other mods (Other then socket lib) and try it. And if it does a list of mods would be nice. Testing locally it seems to work fine on my end. The error seems to be coming from a "cleaner-sheet-title-bar.js" file which I cant find anywhere so I think it might be another module causing issues.

jacobwojoski commented 1 year ago

might have found it. looks like its the cleaner-title-bar module. but dont know for sure. Id see if you can disable it and see if it works. Wondering if its the only thing causing issues

https://foundryvtt.com/packages/cleaner-sheet-title-bar

jacobwojoski commented 1 year ago

Tried installing cleaner sheet title bar and didn't get the error. Think it might be an interaction with another mod. lmk if disabling mods fix it and getting a list of mods would help solve the problem

NVM. Just forgot to enable the module. It should be the one causing the error. lmk if disabling fixes it. Want to know if its the only thing causing issues

brunocalado commented 1 year ago

Referen

It's cleaner sheet title bar fault. What can be done about it? image

Identify the exploding event is hard to add?

jacobwojoski commented 1 year ago

Does it get the exploding die info if cleaner sheet is disabled? Because on my end it appears to record the exploding dice fine. It auto rolls the exploding die for me so idk if you might have a different setting where you manual reroll the exploding die values?

I can look into adding support for cleaner-sheet-title-bar to fix the error.

brunocalado commented 1 year ago

Yes. I disabled cleaner mod

I can't see the exploding dice image

jacobwojoski commented 1 year ago

Will need to investigate. Maybe I don't fully understand exploding dice feature. Will take a photo later to show what I see on my end. In your photo are both 9's made up of more then 1 dice roll? If both are made up of a 6 & a 3 it appears to work? As that would have made 6 3's rolled and you have 6 rolls counted.

brunocalado commented 1 year ago

SWADE dice rolling works like that:

There are two types of actors: Wild Card and Extra Wild Card You roll the Wild Die and the Trait Die. You pick the better roll from them.

Extra You roll the Trait Die.

Trait a skill is a trait

Roll Example Wild Card Skill Notice D8 The player roll D8 and D6 (wild die) Case 1 D8: 6 and D6: 6 and 5 = total 11 Case 2 D8: 8 and 7 and D6: 4 = total 15 Case 3 D8: 1 and D6: 1 = total 1 - critical failure Case 4 D8: 8 and 8 and 8 and 3 and D6: 3 = total 27

FloRad commented 1 year ago

Hi Jacob, I'm the swade system developer! If you have any technical questions about how the system rolls etc work then please feel free to hit me up on Discord! Just ping me in the #swade channel on the FoundryVTT discord and I'll be happy to help you out.

jacobwojoski commented 1 year ago

image

It looks like it works here for me unless the issue is not with Skills? Made 2 skill checks. Second rolled a 6 on the wild die. 3d6 and 2d4 rolled and dice stats says that.

jacobwojoski commented 1 year ago

Exploding d4's seems fine to me too. image Should have 5 total rolls for both dice as expected

Am I missing something here?

brunocalado commented 1 year ago

Exploding d4's seems fine to me too. image Should have 5 total rolls for both dice as expected

Am I missing something here?

Yes. Dice count looks good.

But, the streak looks weird.

jacobwojoski commented 1 year ago

Streak looks fine to me. Streaks are when the player rolled and got results in an incrementing order. Ex: 5,6,7,8 or 15,16,17,18,19,20 You rolled the following: D4 rolls: 2,2,3,4,3 -> Streak of 2,3,4 d6 rolls: 2, 6, 3, 3, 3 -> longest streak of 1 so nothing is displayed. Only when streaks reach 2+ values it gets displayed

What did you expect to see?

brunocalado commented 1 year ago

Oh. I understood.

I thought the streak would be used for the exploding dice. So, You rolled 6 and 3, your streak is 6,3.

But, it's great! Thank you

jacobwojoski commented 1 year ago

Working for SWADE