search

jacobworrel / react-windowed-select

An integration of react-window with react-select to efficiently render large lists.
MIT License
142 stars 38 forks source link

noOptionsMessage and loadingMessage are not passed proper params #19

Closed ghost closed 4 years ago

ghost commented 4 years ago

According to the react-select documentation, noOptionsMessage and loadingMessage must be passed strings. Utils.js calls these functions without the required arguments, which will break if the messages use the strings they expect to be passed.

A workaround is to simply return an empty string if these functions are called with no arguments. This does not seem to affect the displayed message.

jacobworrel commented 4 years ago

Nice catch! Fixed in https://github.com/jacobworrel/react-windowed-select/pull/21