search

jacobworrel / react-windowed-select

An integration of react-window with react-select to efficiently render large lists.
MIT License
142 stars 38 forks source link

Add variable heights for options #34

Closed jchamb closed 4 years ago

jchamb commented 4 years ago

fixes #31 by adding measuring to option items.

Note this could probably be made more efficient with measurement done through portals.

amber-cd commented 4 years ago

Hrm... we forked the PR from this branch and published it to our private NPM repository in order to verify if this fix worked for our use case, but I'm still seeing the issue with overlapping option heights. @jchamb First, thank you for all the work on this so far, and second, is there something I need to add/use in the props in order to use this work?

jacobworrel commented 4 years ago

@amber-cd There are examples in Storybook that work. Were you able to see those working examples in the fork?

jacobworrel commented 4 years ago

see https://github.com/jacobworrel/react-windowed-select/pull/38

jacobworrel commented 4 years ago

@amber-cd just published 2.0.3 to npm with this fix. you can see a working example here: https://peaceful-leavitt-38971b.netlify.app/?path=/story/select--long-label-text no need to do anything on your end to get this working.

amber-cd commented 4 years ago

Fantastic, thank you!

jchamb commented 4 years ago

Sorry everyone had a super busy June and just back getting in here. Glad to see ya'll were able to work this out and get it merged!