search

jacogr / atom-git-control

Not maintained :(
MIT License
227 stars 70 forks source link

Add a pull from upstream button #125

Closed AdamPohl closed 8 years ago

AdamPohl commented 8 years ago

In order to pull from upstream at the moment i have to use the terminal, this is not a major problem but is there a way to add this feature to the package?

MarcelMue commented 8 years ago

There was some discussion ( see #44 ) about github exclusive features. I am unsure about pulling from upstream but am willing to discuss it if someone wants to work on a PR for it.

AdamPohl commented 8 years ago

In the menu-veiw.coffee file you have used the code:
{ id: 'pull', menu: 'Pull', icon: 'pull', type: 'upstream'}
to put the pull button into the menu. Why is the 'type' set as upstream? should it not be origin as that is the git remote it uses.

Thanks :smiling_imp:

AdamPohl commented 8 years ago

Also if I wanted to look at where the id is (see the code in my last comment), would I be right in going to the git.coffee file and looking at the code from line 99 onwards?

Thanks :smiling_imp: