jacogr / atom-git-control

Not maintained :(
MIT License
227 stars 70 forks source link

Cannot read property 'push' of undefined #204

Open gosteev opened 7 years ago

gosteev commented 7 years ago

when i click on 'show diff' icon, i got this error in console. when i write the same in git bash, no error occurs:

image

image

this happens only with this file - diff on any other file works as expected

matkam commented 7 years ago

Seeing the same issue, but my git doesn't output anything about line endings

screen shot 2017-05-04 at 11 10 50 am

~/s/v/c/c/vxl_mesos (master) $ git --no-pager diff recipes/slave.rb 
diff --git a/cookbooks/vxl_mesos/recipes/slave.rb b/cookbooks/vxl_mesos/recipes/slave.rb
index 41c2cd6..5aa0300 100644
--- a/cookbooks/vxl_mesos/recipes/slave.rb
+++ b/cookbooks/vxl_mesos/recipes/slave.rb
@@ -39,6 +39,11 @@ node.set['mesos']['slave']['flags']['attributes'] = 'driver:false'

 include_recipe 'mesos::slave'

+file '/etc/cron.daily/docker-cleanup' do
+  content 'docker system prune -af'
+  mode '0755'
+end
+
 # register service with consul
 consul_params = {
   tags: [node['vxl_service']['mesos']['cluster']],
Arcadia822 commented 7 years ago

Still have this problem in 0.9.0. Compare file with CRLF line endings cause this error