search

jacogr / atom-git-control

Not maintained :(
MIT License
227 stars 70 forks source link

Pane.addItem is deprecated. #225

Closed edarblanco closed 7 years ago

edarblanco commented 7 years ago

Pane::addItem(item, 0) is deprecated in favor of Pane::addItem(item, {index: 0})

Pane.addItem (/usr/lib/atom/src/pane.js:447:14)
Object.toggleView (/home/edar/.atom/packages/git-control/lib/git-control.coffee:50:21)
atom-workspace.<anonymous> (/home/edar/.atom/packages/git-control/lib/git-control.coffee:27:24)
CommandRegistry.handleCommandEvent (/usr/lib/atom/src/command-registry.js:259:29)
handleCommandEvent (/usr/lib/atom/src/command-registry.js:3:59)
CommandRegistry.dispatch (/usr/lib/atom/src/command-registry.js:160:19)
fr4nk commented 7 years ago

Edit: this is already fixed: in #222 and #209 If nobody minds I would quickly fix this and make a pull-request. Will be done in a minute... ;-)

iamchriswick commented 7 years ago

Still get the deprecation message, and I just installed

felipebhz commented 7 years ago

Same here. Just installed today, and still getting this deprecation warning. :-)

Jecko-o commented 7 years ago

Same here.

christianodejesus commented 7 years ago

Same here. I'm running Atom 1.13.1 x64 version in OS X El Capitan.

tadinski commented 7 years ago

+1 same problem

michalsarna commented 7 years ago

+1 same for me

diegobiavati commented 7 years ago
Kelvinmijaya commented 7 years ago

same for me

ichbinder commented 7 years ago

+1 same for me, Linux

aflatto commented 7 years ago

+1 for me , Atom 1.14.1 x64 on Fedora 24

TBusen commented 7 years ago

+1 Win7, Atom 1.14.3

hoquangthaiholy commented 7 years ago

+1 Win10, Atom 1.14.3

efc commented 7 years ago

+1 macOS, Atom 1.14.3

mikedizon commented 7 years ago

+1 macOS, Atom 1.14.3

angelxaces commented 7 years ago

+1 McAtom 1.14.3

PerikiyoXD commented 7 years ago

+1 Xubuntu, Atom 1.14.3

BrenMurrell commented 7 years ago

+1 Windows 10, Atom 1.14.4

GeorgeWL commented 7 years ago

Deprecation Cop still tracks this as a deprecation

Is it a problem with deprecation cop or was this never actually fixed?

lwincenciak commented 7 years ago

+1 here, Win7, Atom 1.14.4

dacacioa commented 7 years ago

+1 here, Win 10, Atom 1.15.0

lacostenycoder commented 7 years ago

+1 Mac OS 10.11.6, Atom 1.15.0 x64

bhusang commented 7 years ago

+1 here, Win 10, Atom 1.15.0

erasmus commented 7 years ago

+1, Mac 10.12.3, Atom 1.15.0

carreirorco commented 7 years ago

+1, Ubuntu 16.04.2 LTS, Atom 1.15.0

GeorgeWL commented 7 years ago

233 might be the reason @carreirorco

blairg commented 7 years ago

Getting this on osx 10.11.6 with Atom 1.15.0 x64 Pane::addItem(item, 0) is deprecated in favor of Pane::addItem(item, {index: 0})

GeorgeWL commented 7 years ago

see #233 @blairg

MarcelMue commented 7 years ago

Merged #222 - to be included in the next minor release.

akaybagorov commented 7 years ago

+1

SpeedrunnerG55 commented 7 years ago

+1 Ubuntu 16.04.2 Atom 1.15.0

rpgzzang0613 commented 7 years ago

+1 Windows10 Atom 1.15.0

miguelmendesnet commented 7 years ago

+1 Mac OS 10.12.3, Atom 1.15.0 x64

GeorgeWL commented 7 years ago

@akaybagorov @SpeedrunnerG55 @rpgzzang0613 @miguelmendesnet

See: https://github.com/jacogr/atom-git-control/issues/225#issuecomment-289303862

NetMango commented 7 years ago

+1 Ubuntu 16.04.2 Atom 1.15.0 x64

adrianvanlan commented 7 years ago

+1

iamchriswick commented 7 years ago

People! It's 2017! Use the reaction feature instead of "+1"...

And, see #225 (comment): fix to be included in the next minor release.

screen shot 2017-04-03 at 19 45 20
MarcelMue commented 7 years ago

Fix is now live in version 0.9.0

GeorgeWL commented 7 years ago

@iamchriswick

I feel like github.com should be smart enough to convert it tbh.

And to do the same with the API.

iamchriswick commented 7 years ago

@GeorgeWL That's the same as asking Facebook to "convert" when someone types "Like" in a comment to be a Like-reaction on the main post. 😂

GeorgeWL commented 7 years ago

@iamchriswick hairy fluff that yeah