search

jacogr / atom-git-control

Not maintained :(
MIT License
227 stars 70 forks source link

addPath method in git-control-view #226

Closed ericcornelissen closed 7 years ago

ericcornelissen commented 7 years ago

I added the method getPath to the git-control-view which in turn will add some extra attributes to the tab element in the workspace, namely are: data-name and data-path.

The reason for this is so packages such as file-icons can easily add an icon to the tab for atom-git-control. As soon as this PR is merged the file-icons packages will add a git icon to the atom-git-control tab.

I created this PR based on an issue on one of my own packages, pinned-tabs, where one of my users requested that the atom-git-control tab would get an icon when it was pinned, see here

Wombosvideo commented 7 years ago

The idea of adding such a feature was from me and I would be happy if this pull request was accepted so the desired functionality can be implemented

EDIT: Well. It wasn't my idea to add the getPath method but to allow file-icons for the git:control tab