search

jacogr / atom-git-control

Not maintained :(
MIT License
227 stars 70 forks source link

Function.extractParams is deprecated. #229

Open nextdevz opened 7 years ago

nextdevz commented 7 years ago

Assigning custom properties to a marker when creating/copying it is deprecated. Please, consider storing the custom properties you need in some other object in your package, keyed by the marker's id property.

Function.extractParams (C:\Users\NextDEV\AppData\Local\atom\app-1.14.3\resources\app.asar\node_modules\text-buffer\lib\marker.js:43:14)
MarkerLayer.markRange (C:\Users\NextDEV\AppData\Local\atom\app-1.14.3\resources\app.asar\node_modules\text-buffer\lib\marker-layer.js:215:71)
DisplayMarkerLayer.markBufferRange (C:\Users\NextDEV\AppData\Local\atom\app-1.14.3\resources\app.asar\node_modules\text-buffer\lib\display-marker-layer.js:105:52)
TextEditor.markBufferRange (C:\Users\NextDEV\AppData\Local\atom\app-1.14.3\resources\app.asar\src\text-editor.js:1736:38)
EditorDiffExtender._createLineMarker (D:\Users\NextDEV\.atom\packages\git-time-machine\node_modules\split-diff\lib\editor-diff-extender.js:95:33)
EditorDiffExtender.highlightLines (D:\Users\NextDEV\.atom\packages\git-time-machine\node_modules\split-diff\lib\editor-diff-extender.js:78:33)
marmistrz commented 7 years ago

Similarly, Pane::addItem(item, 0) is deprecated in favor of Pane::addItem(item, {index: 0})