jacogr / atom-git-control

Not maintained :(
MIT License
227 stars 70 forks source link

Update git-control-view.coffee #247

Open jayspirits opened 6 years ago

jayspirits commented 6 years ago

This is a fix from split of undefined issue. Used 'repo.workingDirectory' from gitRepository object instead of 'path' for setWorkspaceTitle. 'path' is no longer available in the object.

ttristan commented 6 years ago

thanks @jayspirits for those who don't know how to fix until the new version is released: move to C:\Users\[username]\.atom\packages\git-control\lib\git-control-view.coffee and change line 76 to:
@setWorkspaceTitle(git.getRepository().repo.workingDirectory.split('/').reverse()[1])

areichman commented 6 years ago

@ts-de Making that change to line 76 allowed me to load the package, but attempting to select a repo using the "Project" button returns the same error noted in #248.

Generic42 commented 6 years ago

I'm running into the same issues, I made the change that @ts-de suggested, which resolve the first error. However now when trying to switch projects I get the error as detailed in #248

Generic42 commented 6 years ago

I made the additional change referenced here https://github.com/jacogr/atom-git-control/issues/245#issuecomment-336805167

Now I can switch projects properly.

gforge commented 6 years ago

I think you also need to add the workinDirectory in project-dialog.coffe line 46 due to the same issue. I also suspect that line 33 is also affected.

Dharshan2004 commented 6 years ago

Thanks it works

kaizvn commented 5 years ago

please merge this