search

jacogr / atom-git-control

Not maintained :(
MIT License
227 stars 70 forks source link

Changed getRepo() to getRepositories() to avoid deprecated calls #66

Closed wbrbr closed 9 years ago

wbrbr commented 9 years ago

See #64

MarcelMue commented 9 years ago

I thought about this change aswell but the atom docs say here that it would be better to use Promise.all(project.getDirectories().map( project.repositoryForDirectory.bind(project))) Unfortunately I didn't get this to work. I am also not sure what to do if more than one repo is returned? Can this even happen?

wbrbr commented 9 years ago

I also tried it but the project.repositoryForDirectory function doesn't work. And the getRepositories function will only be deprecated in the 2.0 release, and the current version is 0.9.

MarcelMue commented 9 years ago

Yeah you are probably right. I am just kind of annoyed at all the new deprecations popping up constantly and wanted to prevent new ones in the near future. I will merge this pull request now and just hope that not as many new deprecations pop up :D

Thanks again for your contribution :+1: