jaconi-io / helm-charts

Helm charts created and maintained by jaconi
MIT License
4 stars 9 forks source link

feat: adds new chart options to management, signal and dashboard #20

Closed diegocn closed 1 year ago

diegocn commented 1 year ago

This PR aims to add a few new options to configure netbird components like:

That workaround isn't the best approach, definitely, but I did it just for the sake of simplicity and to make the chart run.

A better approach, for example, would be having a configmap with nginx's default.conf snippet templatized to handle that specific ipv6 param (and maybe other params) properly, through the chart itself.

diegocn commented 1 year ago

Hi, @jnodorp-jaconi just bumping up in case you did not receive the PR opened alert.

jnodorp-jaconi commented 1 year ago

@diegocn FYI, I get this error from netbird-management after applying your changes:

panic: unexpected config protocol type grpc

I will change the default back to https. Missed that during review.

diegocn commented 1 year ago

hey @jnodorp-jaconi thanks for the feedback!