search

jacopotarantino / angular-match-media

Angular module to use Bootstrap3 media queries in your angular controllers.
https://jack.ofspades.com/angular-matchmedia-module/
Other
135 stars 37 forks source link

Added a filter #14

Closed bitflower closed 8 years ago

bitflower commented 8 years ago

Hey dude :-)

I have extended you plugin again.

I have added the "media" filter to simply retrieve the matching rule. It also takes some options to "group" several rule names together.

See updated readme for examples.

Cheers!

bitflower commented 8 years ago

Just when creating the PR i thought it might be cleaner to have to filters: one that actually only retrieves the actual rule name and one that does the replace of the % sign.

Let me know your thoughts first.

Bye

jacopotarantino commented 8 years ago

This is pretty good work, thanks! I have a couple comments but could you rebase first? I don't want to comment on things that aren't actually a problem.

bitflower commented 8 years ago

Aww, you're right. Legt me fix this...

bitflower commented 8 years ago

I had a little fight with git so I'm closing the PR and opening a niew one. Hoping it'll turn out good...