Fixed the on method, which broke at the last PR and did some cleanup/refactoring

jacopotarantino / angular-match-media

Angular module to use Bootstrap3 media queries in your angular controllers.

https://jack.ofspades.com/angular-matchmedia-module/

Other

135 stars 37 forks source link

Fixed the on method, which broke at the last PR and did some cleanup/refactoring #25

Closed sravenhorst closed 8 years ago

sravenhorst commented 8 years ago

the .on() method broke at the last PR, fixed.
added a property to the screenSize service: isRetina
Update readme
Refactored some code.

jacopotarantino commented 8 years ago

Thanks for cleaning that up. And sorry for the wait, I didn't get a notification for some reason. In the future could you make PRs for refactoring jobs and the like separately so it's easier for me as a maintainer to vet what's changed? This is pretty huge for me. I'm going to merge this in. Could you please verify that it works for you in a reduced environment? I cleaned up the previous plunkr and made it work with the current code here: http://plnkr.co/edit/cjard9?p=preview