Inconsistent Method Signature for onChange()

jacopotarantino / angular-match-media

Angular module to use Bootstrap3 media queries in your angular controllers.

https://jack.ofspades.com/angular-matchmedia-module/

Other

135 stars 37 forks source link

Inconsistent Method Signature for onChange() #34

Closed edmondchui closed 7 years ago

edmondchui commented 8 years ago

In all methods except onChange(), the scope parameter is always the last parameter. Even the documentation is having the last parameter of onChange() as scope. We need to change it to make it consistent.

jacopotarantino commented 7 years ago

Agreed. I just noticed this while reviewing another PR and it really bothers me. However, I'm not comfortable making a breaking change to the API just because it's inconsistent. I'd rather just write it better next time when I release the Angular2 version of the plugin. I'm going to close this as wontfix for now but feel free to leave a comment or re-open it if you think I'm wrong. I'm open to suggestions.