search

jacopotarantino / angular-match-media

Angular module to use Bootstrap3 media queries in your angular controllers.
https://jack.ofspades.com/angular-matchmedia-module/
Other
135 stars 37 forks source link

Please add minified build file to your repository. #42

Open msfilho opened 7 years ago

msfilho commented 7 years ago

Please add minified build file to your repository.

This help us to use minified files without the need to manually generate across development and production machines. Most libraries developers send the minified files together.

Thank you

jacopotarantino commented 7 years ago

Hey @msfilho! You can actually get the minified version from https://cdnjs.com/libraries/angular-media-queries . CDNJS was kind enough to host the files based on demand. Let me know if that doesn't help.

msfilho commented 7 years ago

Hi @jacopotarantino , thank you for reply.

The problem is not hosting the file. It's self hosted and i can generate the minified myself (already did it).

The problem is the organization of the project. In our project we don't mix public libraries with our libraries and don't add any of the public libraries in our SVN repository. So to add an extra file manually, it goes against the best practices to keep the project working in all our developer machines and production deploy. As a web project, it's not common to have to generate others libraries or anything like that, just download and use it.

Actually your library is the only which do not came with a minified file inside it.

Thank you.