search

jacopotarantino / angular-match-media

Angular module to use Bootstrap3 media queries in your angular controllers.
https://jack.ofspades.com/angular-matchmedia-module/
Other
135 stars 37 forks source link

onRuleChange() is not available in version 0.6.1 listed on npmjs.com #47

Closed bertysentry closed 5 years ago

bertysentry commented 5 years ago

Hi,

This is a great library for AngularJS and thank you for all the effort you put into this project.

Can we please ask you a favor? Release the latest on npm. The onRuleChange() method is not available in the 0.6.1 package listed on npmjs.com (https://www.npmjs.com/package/angular-media-queries), which is shame as it's a very practical function.

Thank you!

jacopotarantino commented 5 years ago

i'm sorry but this repository is no longer maintained as angular@2 has been out for a while and really i just don't have the time for maintenance. if you'd like to use that particular version you can point your package.json to a specific commit or a fork if you need to. i'm also happy to share maintenance credentials.

bertysentry commented 5 years ago

Thank you @jacopotarantino , that's what I did (point to a specific commit). If there are other changes required, I'll submit a PR. Also: while Angular 2+ has been out there for a while, it does not quite replace AngularJS, which many people still prefer over Angular2 ;-)

jacopotarantino commented 5 years ago

hehe. understood. very incidentally: have you looked at vuejs? i view it as a more modern ng1. it has a more similar API unlike ng2 which feels more like a radical departure from ng1.

bertysentry commented 5 years ago

Agreed on vue.js, much more lovable than ng2, imho...