Extended default media queries & maintenance.

jacopotarantino / angular-match-media

Angular module to use Bootstrap3 media queries in your angular controllers.

https://jack.ofspades.com/angular-matchmedia-module/

Other

135 stars 37 forks source link

Extended default media queries & maintenance. #7

Closed bitflower closed 9 years ago

bitflower commented 9 years ago

jslinted (Sublime text gave me a lot errors)
Changed standard resolutions to support 0-479px for really tiny screens
replaced array detection code

jacopotarantino commented 9 years ago

I appreciate the smarter type checking but I can't accept a PR that changes the default spacing.

Also, a change to the breakpoints should involve updated documentation. I'd really like to keep it the same as the Bootstrap defaults just to make the default settings match a common pattern.

If you fix those issues I'd consider merging.

bitflower commented 9 years ago

Hey, sorry for the delay!

I have reverted the default rules.

By "spacing" you mean the formatting of the code?

Cheers!

bitflower commented 9 years ago

I have changed the intendation to 2 spaces.

I have added a new method that only fires if the screen is actually the size of the given breakpoint. See updated doc for example.

Would love to PR this!

Bye

jacopotarantino commented 9 years ago

Thanks so much for keeping up with this. Also, I feel like I should apologize because I did not realize what a mess the spacing was in that file before. Super inconsistent.

Anyway, I'm on board with this. I'm going to merge it and make a few tweaks before I tag it for release.

jacopotarantino commented 9 years ago

Boom. 0.4.0 has your changes in it. Thanks for the contribution!