search

jacques-menu / musicformats

The code base, documentation and examples of textual music scores formats handling and conversions tools
Mozilla Public License 2.0
2 stars 2 forks source link

xml2ly: emit warning for ignored pedal change tag #9

Open lemzwerg opened 3 months ago

lemzwerg commented 3 months ago

[ef5018a8347cc3762c2f0b401e6389e186ff1cba]

Consider the MusicXML file in the attached archive and process it with

xml2ly pedal-change.xml > pedal-change.ly

xml2ly correctly ignores the <pedal type="change"/> element. I suggest to emit a warning accordingly.

pedal-change.zip

jacques-menu commented 3 months ago

Hello Werner,

Thanks for your tests and advice!

I’m currently releasing v0.9.70, and I’ll start looking into the issues you found next week-end.

Stay tuned, and have a happy Easter!

JM

Le 27 mars 2024 à 19:00, Werner Lemberg @.***> a écrit :

[ef5018a https://github.com/jacques-menu/musicformats/commit/ef5018a8347cc3762c2f0b401e6389e186ff1cba]

Consider the MusicXML file in the attached archive and process it with

xml2ly pedal-change.xml > pedal-change.ly xml2ly correctly ignores https://www.w3.org/2021/06/musicxml40/musicxml-reference/data-types/pedal-type/ the element. I suggest to emit a warning accordingly.

pedal-change.zip https://github.com/jacques-menu/musicformats/files/14779357/pedal-change.zip — Reply to this email directly, view it on GitHub https://github.com/jacques-menu/musicformats/issues/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRJX6WUZ2QHIGIRAZVWL53Y2L3L5AVCNFSM6AAAAABFLLT7UCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTCNBUGY2DOOI. You are receiving this because you are subscribed to this thread.

lemzwerg commented 3 months ago

Jacques, I wish you the same!

Please consider LilyPond's MusicXML test suite and compare the output of xml2ly with other programs that have good MusicXML support (I guess this means Dorico, Finale, and Sibelius).

Note, however, that the test suite covers MusicXML 1.0, which is very old. It would be great if this could be updated to a newer standard version...

jacques-menu commented 3 months ago

Hello Werner,

Le 27 mars 2024 à 23:20, Werner Lemberg @.***> a écrit :

Jacques, I wish you the same! Please consider LilyPond's MusicXML test suite and compare the output of xml2ly with other programs that have good MusicXML support (I guess this means Dorico, Finale, and Sibelius).

I’ll look at LilyPond's MusicXML tests.

My Finale and Sibelius licenses are very old and extinct (they date back to Intel processors and OSs I don’t have any longer), and I 've never bought one for Dorico.

Note, however, that the test suite covers MusicXML 1.0, which is very old.

Many of them were taken over from libmusicxml2, are modifications of the latter, or were crafted by hand. It would be great if this could be updated to a newer standard version...

That would be much work, unless it can be done the scripted way. MuseScore re-exports MusicXML 1.0 it has opened as 1.0 too. Do you know of an app that would create 4.0 files from 1.0 ones?

BTW, I’ve never found a TeXLive action for GitHub that runs on all 3 OSes. Do you know of one?

Have a nice day!

JM

lemzwerg commented 3 months ago

I'm not acquainted with MusicXML at all; I'm just looking at bug reports in LilyPond's issue tracker :slightly_smiling_face: This means I have no idea whether there exists a script to convert from older MusicXML versions to newer ones – that is, without 'enriching' the original files with product-specific things (say, by using Finale to import the old MusicXML file, then exporting it again).

Regarding TeXLive actions for GitHub: I suggest that you write to the texlive@tug.org mailing list and ask for guidance.

lemzwerg commented 3 months ago

BTW, I have to correct myself: The MusicXML test suite is for version 2.0, not version 1.0 – at least it uses elements and tags of version 2.0, according to https://www.w3.org/2021/06/musicxml40/version-history/20/

I probably should update the DOCTYPE comment in all files...

jacques-menu commented 3 months ago

Le 28 mars 2024 à 09:59, Werner Lemberg @.***> a écrit :

BTW, I have to correct myself: The MusicXML test suite is for version 2.0, not version 1.0 – at least it uses elements and tags of version 2.0, according to https://www.w3.org/2021/06/musicxml40/version-history/20/

OK. I probably should update the DOCTYPE comment in all files...

Than can be scripted, fortunately.

JM

— Reply to this email directly, view it on GitHub https://github.com/jacques-menu/musicformats/issues/9#issuecomment-2024705115, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRJX6WZZ73QP6QWYFMT3DTY2PEU7AVCNFSM6AAAAABFLLT7UCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRUG4YDKMJRGU. You are receiving this because you commented.