search

jacquescrocker / jammit-s3

Extensions so you can use jammit with s3/cloudfront for your Rails app
http://documentcloud.github.com/jammit/
MIT License
125 stars 31 forks source link

Expire headers #2

Closed fbjork closed 13 years ago

fbjork commented 13 years ago

Any chance of getting expire headers support added?

jacquescrocker commented 13 years ago

definitely. can you take a look and post a patch? i'll merge asap

fbjork commented 13 years ago

I'll have a look at it and submit a pull request

jigardoshi commented 13 years ago

I am hoping this change would include a "Cache-Control" header as well.

kmamykin commented 13 years ago

Cache-Control support is already there, just define s3_cache_control config setting like this: s3_cache_control: public, max-age=<%= 365 * 24 * 60 * 60 %>

jumph4x commented 13 years ago

Was the expires header ever added? I don't see it.

Should we reopen the issue? let me know if you'd like a pull request.