search

jacquescrocker / jammit-s3

Extensions so you can use jammit with s3/cloudfront for your Rails app
http://documentcloud.github.com/jammit/
MIT License
124 stars 31 forks source link

asset_host #9

Open fbjork opened 13 years ago

fbjork commented 13 years ago

Hey,

just out of curiosity why is the asset_host being set in jammit-s3? Why not leave it to the environment specific config.action_controller.asset_host value?

kmamykin commented 13 years ago

IMHO having all settings in one place (assets.yml) simplify maintenance

fbjork commented 13 years ago

When used with other gems like Carrerwave the asset_host manipulation done with jammit-s3 breaks functionality.

kmamykin commented 13 years ago

Jammit-s3 sets asset_host in before_configuration block when initializing. So if it conflicts with anything, override it in config/environments/production.rb as usual. I saw your commit when you moved the setting from the gem but did not understand the reasoning.