search

jacquesfize / GMatch4py

A graph matching library for Python
MIT License
193 stars 40 forks source link

Deepwalk is a node embedding algorithm. #6

Closed benedekrozemberczki closed 5 years ago

benedekrozemberczki commented 5 years ago

Deepwalk is a node embedding algorithm (graph embedding ≠ node embedding). As each run of a node embedding can be rotated with an orthogonal rotation matrix doing any sort of comparison of two node embedding is totally meaningless. I am also somewhat surprised to see large blocks of code from my graph2vec repository.

jacquesfize commented 5 years ago

Hi @benedekrozemberczki,

You're right, DeepWalk isn't a graph embedding algorithm, I'll change that in the next version.

As for graph2vec, I reused your code and join a reference to it.

https://github.com/Jacobe2169/GMatch4py/blob/1784921049ac4cb00fc9d819038202b84e82dea2/gmatch4py/embedding/graph2vec.pyx#L170

Also, your paper is referenced in the README. If you wish your repo to be explicitly referenced in the README page, let me know !

Bests, Jacques