search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
450 stars 26 forks source link

Columns UI/Tab stack: Warning: OpenLyrics Panel panel was visible on creation #132

Closed pierx closed 2 years ago

pierx commented 2 years ago

I got this warning log from Console when OpenLyrics Panel added to the tab stack layout Columns UI/Tab stack: Warning: OpenLyrics Panel panel was visible on creation! This usually indicates a bug in this panel.

jacquesh commented 2 years ago

Thanks for reporting.

Notes for myself when I get round to this: This is getting logged from here: https://github.com/reupen/columns_ui/blob/f5d79b98adc11c5b1a119cd3cfecf57e246e8741/foo_ui_columns/splitter_tabs.cpp#L721

Seems like a minor issue since ColumnsUI can just automatically hide the panel. Developer docs for ColumnsUI are a bit thin, but I suspect ColumnsUI is passing us some parameters on window creation that we're not taking into account.

pierx commented 2 years ago

Yeah, it's just a minor issue. Thanks for taking the time to look into it!