search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
429 stars 24 forks source link

Feature suggestion: Exclude tracks by genre #142

Closed HeresJonny closed 1 year ago

HeresJonny commented 2 years ago

Some type of music will always be instrumental, like most Jazz and classical music. It would be great to exclude tracks by genre (user definable) from automated and batch searches.

jacquesh commented 2 years ago

I'm not sure this would be worth the additional complexity.

Tracks without lyrics will eventually become excluded automatically by virtue of lyrics not being found in the regular autosearches. If you really want to skip those tracks from the get-go you can always manually mark them as instrumental. This would be even simpler to do in bulk with #113

HeresJonny commented 2 years ago

This feature would save some calls, though... the online databases would probably appreciate it.

jacquesh commented 1 year ago

I think #202 would be a better implementation of this, since it would provide the flexibility to do exactly what you suggest here but without being tied specifically to genre (so users can check the genre tag if they want, but could also check their own custom tag, or the file path, or whatever).