search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
429 stars 24 forks source link

Don't connect to disabled sources when Manually searching #149

Open Rexadev opened 2 years ago

Rexadev commented 2 years ago

foobar connects to - 163.com qq.com darklyrics.com

I have enabled only these- Tag File MusixMatch Genius AZLyrics

jacquesh commented 2 years ago

Right now that should only be the case for manual search (which currently always searches every source on the logic that you should be doing it relatively infrequently and you're specifically asking for it which means the normal, automated search was in some way insufficient).

Can you confirm that manual search is what you're referring to?

Rexadev commented 2 years ago

If user has disabled a source from using it for auto-search that means user doesn't want lyrics from that source. Sources are in a order. And using disabled source for manually search is counter intuitive. @jacquesh

Rexadev commented 1 year ago

In manual search first search by Enabled sources then search by disabled sources (because you what to).

Velocidensity commented 10 months ago

I find myself using the manual search fairly frequently, so this would be a great addition. An ideal solution IMO would be a three category solution: sources used for all searches, sources only for manual searches, sources never used.

Rexadev commented 1 week ago

@jacquesh In bulk search does openlyrics search with only selected sources or all like in manual search ?

jacquesh commented 1 week ago

In bulk search does openlyrics search with only selected sources or all like in manual search ?

Bulk search works like the auto-search (and fundamentally it has to, because in order be like manual search it would need to give you a UI for selecting the result).

ngs428 commented 53 minutes ago

Summarizing my comments into this open issue. Originally I opened #400 which is this same request. My thoughts on this topic are as follows:

In the other lyric components if a source is on the right side, it should not be used in queries. That is the point of moving them between columns.

I use manual search as my main mode to find lyrics, probably 95% of the time (if I am not using LSP in bulk, but hopefully yours in the future). Seems like unnecessary searches and results from sources we don’t want searched.

It would be nice if this could be revisited. Several users have brought this up, and it is counterintuitive to the way the other programs work.

As more sources are added this current process of searching all sources in manual mode will render many unintended queries. The current way of handling sources worked well when there were only a few sources, but it is not feasible in the future as more sources are added. This will hit the servers will additional, I will call it, unintended queries. LRCLib I have seen too returns a bunch of results, so the results list is getting very long and I only care about maybe 2 sources at the moment to get what I need.

Hopefully you can work this into development. Adding sources is a good thing, just need this to grow with it. Thanks again for the best in class lyric component. I has helped me quite a bit over the years!