search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
450 stars 26 forks source link

[Reopen this][Enhancement] In Autosearch only use AlbumArtist or 1st Artist when separator is preset #165

Closed Rexadev closed 2 years ago

Rexadev commented 2 years ago

Search doesn't work in songs with multiple artists having metadata in format Artist1; Artist2 or Artist1, Artist2

jacquesh commented 2 years ago

We already search for only the first instance of a tag, so if you want to include multiple artists but only search for one, put them in separate "artist" tags. I don't want to do text processing on the tag values to split by comma or semicolon or whatever.

Rexadev commented 2 years ago

Screenshot 2022-09-11 000337 @jacquesh related bug

jacquesh commented 2 years ago

Please don't sneak bug reports into the comments on a feature suggestion. Create a new issue.

I assume you mean the fact that when you open the manual search it populates artist with only "Samra" and not the other two. I expect that metadata panel is showing the value of all the tags, separated by semi-colons in which case this is working as intended.

Rexadev commented 2 years ago

Please don't sneak bug reports into the comments on a feature suggestion. Create a new issue.

OK but I thought it is related so...

I expect that metadata panel is showing the value of all the tags, separated by semi-colons in which case this is working as intended.

I asked you to only search bt first artist but you said that is a bad idea and now I am saying open_lyrics automatically only using first artist

jacquesh commented 2 years ago

OK but I thought it is related so...

True, but its easier to manage if bugs and feature suggestions are in separate issues (and if there's only 1 bug/feature in each issue). :)

I asked you to only search bt first artist but you said that is a bad idea and now I am saying open_lyrics automatically only using first artist

There are 2 possible scenarios: 1) A track has 2+ artists, each in a separate copy of the "ARTIST" tag or 2) The track has 2+ artists all strung together in the same tag.

I'm saying we already search only the first artist in case 1 and I don't want to try to specifically solve case 2. If you can demonstrate that what you have is an instance of case 1 and it's not behaving as expected then we have a bug, otherwise I don't think there's anything to do here. If you'd like to claim that its not behaving as expected then please can you provide specific examples and logs (as per the bug report template) and we can re-open this as a bug.

Rexadev commented 2 years ago

I'm saying we already search only the first artist in case 1 and I don't want to try to specifically solve case 2. If you can demonstrate that what you have is an instance of case 1 and it's not behaving as expected then we have a bug, otherwise I don't think there's anything to do here. If you'd like to claim that its not behaving as expected then please can you provide specific examples and logs (as per the bug report template) and we can re-open this as a bug.

I am using 2) and I get only first artist

Rexadev commented 2 months ago

I have a good reason - SOurces like Genius and AZLyrics almost always works when only using Album/Main Artist

Related https://github.com/jacquesh/foo_openlyrics/issues/196

@jacquesh