search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
429 stars 24 forks source link

[Reopen this] Lyrics translation and MusixMatch translation support #170

Closed Rexadev closed 2 years ago

Rexadev commented 2 years ago
  • How you think the new feature/improvement would be helpful, or what problem you think it would solve

Very obvious but,

  1. Good for listening to music that the user doesn't speak language of.
  2. Help in learning language.

I found this I don't if will help - https://github.com/Spikatrix/Traly https://github.com/markzhai/LrcCleaner https://github.com/brandonw3612/TranslateLrc https://github.com/slowfog/LrcSpliter https://github.com/marz1877/SyncedLyrics-.lrc_v2

More people are interested in Translation https://www.reddit.com/r/foobar2000/comments/y35b04/comment/isba0jm/?context=3

jacquesh commented 2 years ago

Please provide addition information, as mandated in the feature request template. Closing until then.

Is this even something musixmatch provides? Can you link to any documentation on it?

On the balance of it, I probably wouldn't want to add this anyway (at least without many people asking for it) because of the amount of complication it would introduce.

Rexadev commented 2 years ago

Is this even something musixmatch provides? Can you link to any documentation on it?

https://www.musixmatch.com/lyrics/Lana-Del-Rey/Venice-Bitch/translation/german https://www.youtube.com/watch?v=Cdj87UTuKQ8 https://support.musixmatch.com/article/89-how-can-i-display-the-lyrics-translation

On the balance of it, I probably wouldn't want to add this anyway (at least without many people asking for it) because of the amount of complication it would introduce.

Add option in setting to turn it on/off.

jacquesh commented 2 years ago

Add option in setting to turn in on/off.

No. That would be more complication.

Rexadev commented 2 years ago

Add option in setting to turn in on/off.

No. That would be more complication.

I mean on and off option for downloading translations. Not translated lines

jacquesh commented 1 year ago

Maybe, but realistically, probably not. The problem isn't doing the work to add it, the problem is that I don't think translation really falls into the realm of "things openlyrics should concern itself with" and that once its added I have to maintain it for all time or risk the wrath of users if I take it out later in pursuit of simplicity.

Rexadev commented 4 weeks ago

@jacquesh reconsider this please