[Feature] Source Metadata in Lyrics

Rexadev commented 1 year ago

How you think the new feature/improvement would be helpful, or what problem you think it would solve

I prefer lyrics from Genius. but there are already lyrics in my files from auto search . If I manual search I will be able to tell if the lyrics is from my preferred source.

use [source:*] or [re:The player or editor that created the LRC file]

If using should re: it will not show in lyrics and if you put source at the end of lyrics it will.

Add option in preferences.

jacquesh commented 1 year ago

I'm leaning towards "probably not".

If you don't have lyrics and you want lyrics from a particular source you can just only enable that source. If you have lyrics and they're bad/wrong then you can manual search for the correct ones. If you have lyrics and they're correct/fine then its irrelevant, you just use those.

Rexadev commented 1 year ago

I PREFFER Genius because of their formatting and big community editing it. Sometimes artist/label them selves upload there it earlier was marked "verified lyrics"

If you don't have lyrics and you want lyrics from a particular source you can just only enable that source.

~No lyrics are better than bad lyrics.~ Bad lyrics are better than no lyrics.

If you have lyrics and they're bad/wrong then you can manual search for the correct ones. If you have lyrics and they're correct/fine then its irrelevant, you just use those.

I just know genius is always better and it will be easier if marked.

@jacquesh

jacquesh commented 11 months ago

It's not scheduled for a particular release (as can be seen from the lack of an assigned milestone) but it's not been discarded entirely (as can be seen from the fact that the ticket is still open).

Although now that you mention it, this would be covered by #52. It wouldn't be visible as part of the lyric text but we'd obviously need to be storing this info somewhere for it to be retrievable (via right-click -> lyric info/about/whatever). So actually I'm going to say this is a duplicate and we can track it there.

I don't think it makes sense to store it in the lyric text because that's easy for LRC but complicated for normal text files (users almost certainly wouldn't want to permanently see "retrieved from Genius.com" or whatever at the top of your unsynced lyrics) and I'd want a solution that works for both.

Rexadev commented 5 months ago

It's not scheduled for a particular release (as can be seen from the lack of an assigned milestone) but it's not been discarded entirely (as can be seen from the fact that the ticket is still open).

Please reopen this issue

Although now that you mention it, this would be covered by #52. It wouldn't be visible as part of the lyric text but we'd obviously need to be storing this info somewhere for it to be retrievable (via right-click -> lyric info/about/whatever). So actually I'm going to say this is a duplicate and we can track it there.

I don't think it makes sense to store it in the lyric text because that's easy for LRC but complicated for normal text files (users almost certainly wouldn't want to permanently see "retrieved from Genius.com" or whatever at the top of your unsynced lyrics) and I'd want a solution that works for both.

Store it as metadata example -

[sr:genius.com]

[ar:Lyrics artist]

[al:Album where the song is from]

[ti:Lyrics (song) title]

[au:Creator of the Songtext]
[length:How long the song is]
[by:Creator of the LRC file]

[offset:+/- Overall timestamp adjustment in milliseconds, + shifts time up, - shifts down i.e. a positive value causes lyrics to appear sooner, a negative value causes them to appear later]

[re:The player or editor that created the LRC file]

[ve:version of program]

@jacquesh

jacquesh / foo_openlyrics

[Feature] Source Metadata in Lyrics #187