search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
402 stars 24 forks source link

[Performance] Don't search lyrics on Internet when offline. #188

Open Rexadev opened 1 year ago

Rexadev commented 1 year ago
  • How you think the new feature/improvement would be helpful, or what problem you think it would solve

Not count against" lyrics not found will not auto search" Save CPU and Battery

jacquesh commented 1 year ago

Good idea, although off the top of my head I'm not entirely sure how to characterise "when offline". Windows has some mechanism for determining this so we may be able to hook into that. Will require some investigation.

Rexadev commented 11 months ago

Good idea, although off the top of my head I'm not entirely sure how to characterise "when offline". Windows has some mechanism for determining this so we may be able to hook into that. Will require some investigation.

Just Ping 1.1.1.1 or 9.9.9.9 on start up and every 2 minutes then

Rexadev commented 4 months ago

@marc2k3 will you please help with this ?

marc2k3 commented 4 months ago

No idea why I'm being pinged on this, But I searched and found this component is using http_client from the fb2k SDK exactly like I do. I know from experience it takes around 10 seconds to timeout when offline. So what? I've lived with it for years and so have many others. It's a big nothing burger.

If people want to re-invent the wheel to get an "instant" fail, that's on them.

Rexadev commented 4 months ago

@marc2k3 sorry for pinging you I saw you sharing your f2k dev experience on the component repo so i thought I should ask you. if you say i would ping you again.