jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
449 stars 26 forks source link

[Feature request] navigate a song using OpenLyrics #194

Open SUCM opened 2 years ago

SUCM commented 2 years ago

Hi,

borrowing the idea from Lyric Show Modoki to make lyrics time editing and producing easier. is it possible to add at least below functions?

jacquesh commented 2 years ago

For seeking to the clicked line: Do you mean in the editor or in the display panel? Seeking to clicked lyric lines in the display panel is covered in #179. Doing something similar in the editor would be a separate feature.

For scrolling: Can you explain a bit more what it is you envision? A gif/video would be helpful too, if the project you linked already supports it.

SUCM commented 2 years ago

the clickable part is similar idea as ESLyric mentioned in #179, but somewhat different. over all I would like to be able to click on any line (either a sentence or an empty line...etc) in display panel and have playback immediately jump to the time of that line. this will make OpenLyrics highlight that line as well. this is very useful for me to verify if synced time for a line is correct or need to be adjusted

as for scrolling part, current display panel doesn't allow you to scroll through lyric of whole song if it doesn't fit within panel. I would like to able to scroll up or down without impacting highlight line or playback. this would be similar to scroll up and down in playlist while current playing song is highlighted without impacting playback

jacquesh commented 2 years ago

the clickable part is similar idea as ESLyric mentioned in https://github.com/jacquesh/foo_openlyrics/issues/179, but somewhat different. over all I would like to be able to click on any line (either a sentence or an empty line...etc) in display panel and have playback immediately jump to the time of that line. this will make OpenLyrics highlight that line as well. this is very useful for me to verify if synced time for a line is correct or need to be adjusted

That is exactly what I was thinking for #179 (although I realise thats not quite what's shown in the video attached there) :)

As for scrolling: OpenLyrics specifically does not support scrolling when automated scrolling is enabled. If you go to Preferences->OpenLyrics->Display and set "Scroll type" to "Manual" you should be able to scroll (either with the mouse wheel or by dragging).

I'd consider adding a 3rd option to allow scrolling on top of the automated scroll, but for now does the manual scrolling do what you're looking for?

SUCM commented 2 years ago

for now, manual scrolling does allow the scrolling I want to, but clicking on a line doesn't jump playback to that line. perhaps you can give Lyric Show Modoki a try (it requires JScript Panel v1.3.0) for click to jump to playback lyrics line?

OpenLyrics' manual scrolling mode doesn't highlight the current playback lyric line, so it doesn't help to differentiate which lines to look for especially if a song have multiple repeating but slightly different lyrics blocks. going into config to switch between manual and auto scrolling mode is also not fun to do for adjusting lyrics

jacquesh commented 2 years ago

Right right, yes of course. When I mentioned manual scroll I was thinking more along the lines of "this doesn't have all the other things you're asking for but at least the scrolling behaviour* is what you describe.``