search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
407 stars 24 forks source link

[Feature][Performance]Cache search results in Autosearch. #195

Closed Rexadev closed 1 year ago

Rexadev commented 1 year ago

How you think the new feature/improvement would be helpful, or what problem you think it would solve

When manually searching for lyrics after foo_openlyrics has automatically searched for it, it will make it faster to search and choose which lyrics user wants

If there are similar features already, why the new feature/enhancement would be an improvement over those

No

jacquesh commented 1 year ago

I think not. It seems like the benefit wouldn't be worthwhile because:

  1. My general assumption is that manual search is comparatively rare (autosearch usually finds something reasonable and you edit from there, if it doesn't you manual search once, save the result and then you're done for that track, possibly with some editing later) and so it wouldn't really be adding all that much value.
  2. If you're manual searching then presumably it has already done an autosearch and you didn't like the result, so making it immediately provide that result wouldn't help much anyway.
  3. If you have auto-save enabled (which you generally should) then it will find the saved lyrics almost immediately.

It's true that this would reduce load on the lyric sources, but as long as point 1 is true for the majority of users, the difference is pretty small (and probably not worth the complexity).

Rexadev commented 1 year ago

User if wants then can re-search

Rexadev commented 5 months ago

@jacquesh Please reconsider this feature