jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
407 stars 24 forks source link

File name format doesn't create folders #201

Closed regorxxx closed 1 year ago

regorxxx commented 1 year ago

File name format doesn't accept folder levels, although the displayed example works fine (image 1). Backslashes are converted to '-' image

So the subfolder must always be put at the directory TF. image

Steps to reproduce

  1. Put on file name format: lyrics[%Track% - ][%title%]
  2. Save a lyric file
  3. Will be saved into the custom directory format (for ex. C:\TEST) but not at C:\TEST\lyrics..... Filename will be 'lyrics - [%Track% - ][%title%]'

Expected behavior

File name should also create subfolders.

Versions

jacquesh commented 1 year ago

I'm fairly certain this was by design (and is why the two fields are specifically named "file name" and "directory"). Although off the top of my head right now I can't think of a good user-facing reason to actually enforce it.

If you're using "Custom directory" for the directory then I don't think there's any reason why you'd specifically need this but in other cases it provides more flexibility (maybe you want it next to the track but in a lyrics subdirectory, as in your example, although you could already achieve that with the formatted custom directory so ¯\(ツ)/¯).

regorxxx commented 1 year ago

In either case that's a bug (display or functionality). Lyrics 3 allows to do that btw.

Now about why to allow that... note only the custom directory option allows to create folder image

But what about saving lyrics using the other 2 options? You can not create subfolders, since the track TF doesn't allow it image image

So that was the original reason to support it in Lyrics 3. To create nested levels in the other 2 options.

I understand you can already mimic the other 2 behaviors with the custom format directory, but it requires more TF work. In any case, either the displayed result should be fixed or folders allowed to not confuse final users.