search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
450 stars 26 forks source link

Add QQ music support for lyric retrieval #21

Closed snowbie closed 3 years ago

snowbie commented 3 years ago

foo_qqmusiclyricssource.zip

I've decompiled the dlls of the QQ lyric finder for LyricShowPanel3 if it helps provide the necessary information needed for lyric retrieval. I was going to to merge it myself, but it's structured too differently for me to convert it 1:1 for openlyrics. With QQ support I can finally remove LyricShow3 altogether.

veksha commented 3 years ago

hi, @snowbie what tool you used to "decompile" my dlls? i think this decompilation contains no human readable code. for qq lyrics implementation just look here qqmusic_plus.js

snowbie commented 3 years ago

hi, @snowbie what tool you used to "decompile" my dlls? i think this decompilation contains no human readable code. for qq lyrics implementation just look here qqmusic_plus.js

ah, those were by you? Apologies. I had difficulty finding the source because I had originally grabbed the foobar component off of a forum, and googling never led me to the github page. The software is strictly for decompiling dlls to c, so evidently that's where the problem lies as your plugin was written in js.

While I never thought the code itself would be usable, I assumed whatever pieces of code that called certain hex values could've viable.

jacquesh commented 3 years ago

Indeed that decompilation is not helpful. Points for effort though :)

Support for QQMusic has been on my TODO list for ages, it's just a matter of having the time and motivation to put in the work.

Having a reference is super helpful though, thanks @veksha! I had previously resorted to checking wireshark traces in an effort to reverse-engineer existing plugins >_<