search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
433 stars 25 forks source link

[Feature request] Shortcut for Next Lyrics and Save Lyrics #211

Open Hosify opened 1 year ago

Hosify commented 1 year ago

image

There are just few of actions of Openlyrics, Can you add Next lyrics and Save lyrics？

Thanks.

jacquesh commented 1 year ago

I can add one for "Save lyrics" but openlyrics doesn't expose a "Next lyrics" at all (the auto-search only retrieves one set of lyrics, if you want something more complete there's always the manual search).

Hosify commented 1 year ago

image

Lyrics Show 3 have those features, Maybe it can give you some clues, hoping it can help.

And thanks anyway.

regorxxx commented 1 year ago

Just commenting to show interest about this feature. Being able to just fetch another lyric if the current one is not right, would be great. Most people don't want to perform the advanced search, just retry with a new one -by search order- for those cases where the lyrics are wrong.

Foobartius commented 1 month ago

I too would love to see this feature added.

Thank you for your work on this component.

Rexadev commented 1 month ago

https://github.com/jacquesh/foo_openlyrics/issues/163

jacquesh commented 3 days ago

It just occurred to me that since we now track the source of the loaded lyrics, this could conceivably be implemented by passing a "continue-from"-type, pagination-esque parameter to the search and have it just ignore all sources before the given one (the one that current lyrics were loaded from).

Admittedly this would be complicated by things like sources returning multiple lyrics, because we'd want to go through all of those first before moving onto the next source (e.g if you have both a .txt and a .lrc file available locally).