jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
433 stars 25 forks source link

Bug with "Collapse multiple instances of the same line when saving timestamped lyrics" setting #214

Closed Shinisuryu closed 1 year ago

Shinisuryu commented 1 year ago

Unsure if this is intended behavior or not, the wording sounds like it only applies if timestamped lyrics are being saved. But if saving non-timestamped lyrics it would do nothing.

When saving non-timestamped lyrics with the "Collapse multiple instances of the same line when saving timestamped lyrics" setting enabled causes the lyric lines to be sorted alphabetically.

Steps to reproduce

  1. Enable "Collapse multiple instances of the same line when saving timestamped lyrics" setting.
  2. Play music file with non-timestamped or unsynced lyrics.
  3. Tell OpenLyrics to save the current lyrics.
  4. Check the file tags or restart playback to see the lyric sorting change in the lyric display panel.

Expected behavior

OpenLyrics to save the current lyrics to the tag without changing the line order.

Versions

Additional information

Nothing shows in the logs.