search

jacquesh / foo_openlyrics

An open-source lyric display panel for foobar2000
MIT License
402 stars 24 forks source link

[Feature] Search for Synced Lyrics Only #215

Open Rexadev opened 1 year ago

Rexadev commented 1 year ago

Related : https://github.com/jacquesh/foo_openlyrics/issues/219 https://github.com/jacquesh/foo_openlyrics/issues/195

Alternative solution: Show the first lyrics found then after the search is complete switch to the ""best" one https://github.com/jacquesh/foo_openlyrics/issues/345 Somewhat related: https://github.com/jacquesh/foo_openlyrics/issues/149

Alternative Option 2: Add a checkbox to filter results to show only synced lyrics

  • How you think the new feature/improvement would be helpful, or what problem you think it would solve

If user wants to automatedly get Synced Lyrics they have to only select MusixMatch in Preferences then SelectSongs>RightClick>SearchForLyrics. MusixMatch has both Synced and Unsynced Lyrics and foo_openlyrics sometimes prefers unsynced.

jacquesh commented 1 year ago

I suspect this is down to the ordering. The current auto-search will always take the first valid result, but since some sources will return a mix of synced and unsynced lyrics, its possible that their search result list includes unsynced lyrics as the first result even when later results include synced lyrics.

We could add an option to completely exclude unsynced lyrics but setting up the options for this will be a bit complicated to do in such a way that we prevent invalid/nonsensical setups (e.g you only have a single source configured and it will never return synced lyrics but you've specified that you only want synced lyrics).

I suppose maybe its about time we do a larger push on enforcing globally-valid configurations (other options that come to mind include having no sources configured, or not including the source that you save to, or including your save source, but not as the first source in the search order).

Velocidensity commented 9 months ago

This would be great, both as a context menu option, and as a preference. I never want unsynced lyrics, so I'd like it to keep searching until it finds synced lyrics, and only if not, then fall back to unsynced.

Rexadev commented 4 months ago

Alternative Option 2: Add a checkbox to filter results to show only synced lyrics Also check main thread please @jacquesh